Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: atlas pull plugins translation | FC-0012 #33922

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat: atlas pull plugins translation | FC-0012 #33922

merged 1 commit into from
Feb 1, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Dec 13, 2023 •
edited
Loading

Translate edx_django_utils.plugins plugins.

Add two new commands:

  • pull_plugin_translations
  • compile_plugin_translations

TODO

Refs

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 13, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 13, 2023 •
edited
Loading

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi mentioned this pull request Jan 10, 2024
Merged
2 tasks
@OmarIthawi
Copy link
Member Author

@feanil this is the last edx-platform pull request (hopefully).

Please take a look at it before I refactor and add tests.

My top question at the moment is whether the plugins i18n tooling should live here or in edx_django_utils.plugins. I'm happy to try to develop a list of pros/cons if you don't have a quick answer.

The current implementation pulls the following plugins correctly:

  • bluk_grades
  • completion
  • edx_name_affirmation
  • edx_proctoring
  • and others

It doesn't pull edx_enterprise because it's a package but don't have an lms.djangoapp entrypoint. Also, edx-enterprise has no translations at all. So fixing the edx_enterprise is actually needs to happen in the edx-enterprise repository.

@OmarIthawi OmarIthawi requested a review from feanil January 16, 2024 19:57
feanil
feanil reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach generally looks good to me, are we going to have to extrapolate this to the other IDAs eventually?

common/djangoapps/xblock_django/management/commands/pull_xblock_translations.py Show resolved Hide resolved
@OmarIthawi OmarIthawi requested a review from feanil January 17, 2024 20:01
@OmarIthawi OmarIthawi mentioned this pull request Jan 24, 2024
Merged
2 tasks
@OmarIthawi OmarIthawi force-pushed the plugins-i18n branch 2 times, most recently from 54af409 to 363e790 Compare January 25, 2024 21:28
@OmarIthawi OmarIthawi marked this pull request as ready for review January 26, 2024 09:23
@OmarIthawi OmarIthawi force-pushed the plugins-i18n branch 2 times, most recently from e725aca to d4eb538 Compare January 26, 2024 19:02
@OmarIthawi
Copy link
Member Author

@feanil This pull request is ready now for review and merge. I've tested it and it worked well.

We can refactor it and move utilities into openedx-atlas and edx-django-utils to allow other IDAs to translate plugins. Otherwise, we can merge it as-is.

cc: @brian-smith-tcril

@OmarIthawi OmarIthawi mentioned this pull request Jan 28, 2024
Open
@feanil feanil merged commit e6333d0 into openedx:master Feb 1, 2024
64 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@OmarIthawi OmarIthawi mentioned this pull request Feb 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

@brian-smith-tcril brian-smith-tcril Awaiting requested review from brian-smith-tcril

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OmarIthawi @openedx-webhooks @edx-pipeline-bot @feanil @brian-smith-tcril